linux-kernel - Re: [PATCH v2] ktest: introduce REBOOT_RETURN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190418112607.0923e5df@gandalf.local.home>
Date:   Thu, 18 Apr 2019 11:26:07 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masayoshi Mizuma <msys.mizuma@...il.com>
Cc:     Masayoshi Mizuma <m.mizuma@...fujitsu.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ktest: introduce REBOOT_RETURN_CODE to confirm the
 result of REBOOT

On Thu, 18 Apr 2019 09:59:43 -0400
Masayoshi Mizuma <msys.mizuma@...il.com> wrote:

> From: Masayoshi Mizuma <m.mizuma@...fujitsu.com>
> 
> Unexpected power cycle occurs while the installation of the
> kernel.
> 
>    ssh root@...t sync ... [0 seconds] SUCCESS
>    ssh root@...t reboot ... [1 second] FAILED!
>    virsh destroy Test; sleep 5; virsh start Test ... [6 seconds] SUCCESS
> 
> That is because REBOOT, the default is "ssh $SSH_USER@...CHINE
> reboot", exits as 255 even if the reboot is successfully done,
> like as:
> 
>    ]# ssh root@...t reboot
>    Connection to Test closed by remote host.
>    ]# echo $?
>    255
>    ]#
> 
> To avoid the unexpected power cycle, introduce a new parameter,
> REBOOT_RETURN_CODE to judge whether REBOOT is successfully done
> or not.
> 

Thanks for sending the patch. I added it to my local queue, and will
use it for testing of my changes to the Linux kernel, and it will
eventually be merged upstream.

-- Steve