linux-kernel - Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Apr 2019 19:12:13 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Takashi Iwai <tiwai@...e.de>, Pavel Machek <pavel@....cz>
Cc:     linux-leds@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        dtor@...gle.com, robh@...nel.org, Jaroslav Kysela <perex@...ex.cz>,
        linux@...ck-us.net, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

On 4/18/19 2:24 PM, Takashi Iwai wrote:
> On Thu, 18 Apr 2019 14:21:35 +0200,
> Pavel Machek wrote:
>>
>> On Thu 2019-04-18 07:17:54, Takashi Iwai wrote:
>>> On Wed, 17 Apr 2019 22:54:14 +0200,
>>> Jacek Anaszewski wrote:
>>>>
>>>> led_colors clashes with the array of the same name being added
>>>> to the LED class. Do the following amendments to fix this issue
>>>> and the other prospective one.
>>>>
>>>> led_colors -> toneport_led_colors
>>>> led_init_vals -> toneport_led_init_vals
>>>>
>>>> Fixes: f44edd7b2bbed ("ALSA: line6/toneport: Implement LED controls via LED class")
>>>> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
>>>> Cc: Jaroslav Kysela <perex@...ex.cz>
>>>> Cc: Takashi Iwai <tiwai@...e.com>
>>>> Cc: Arnd Bergmann <arnd@...db.de>
>>>
>>> Looks good.
>>>
>>> Feel free to take my ack:
>>>    Reviewed-by: Takashi Iwai <tiwai@...e.de>

Thanks.

>> I guess this is independend of pretty much everything, and should be
>> taken through the sound tree?
> 
> I don't mind either way.  If it's easier for you to take through sound
> tree, just let me know.

I prefer to take it via LED tree as this patch is needed
by the LED naming set.

-- 
Best regards,
Jacek Anaszewski