linux-kernel - Re: [PATCH v3 3/4] spi: Patch Macronix SPI controller driver according to MX25F0A MFD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190419145151.GR2803@sirena.org.uk>
Date:   Fri, 19 Apr 2019 15:51:51 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Mason Yang <masonccyang@...c.com.tw>
Cc:     marek.vasut@...il.com, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, bbrezillon@...nel.org,
        dwmw2@...radead.org, lee.jones@...aro.org, robh+dt@...nel.org,
        mark.rutland@....com, computersforpeace@...l.com,
        paul.burton@...s.com, stefan@...er.ch, christophe.kerello@...com,
        liang.yang@...ogic.com, geert@...ux-m68k.org,
        devicetree@...r.kernel.org, marcel.ziswiler@...adex.com,
        linux-mtd@...ts.infradead.org, richard@....at,
        miquel.raynal@...tlin.com, juliensu@...c.com.tw,
        zhengxunli@...c.com.tw
Subject: Re: [PATCH v3 3/4] spi: Patch Macronix SPI controller driver
 according to MX25F0A MFD driver

On Mon, Apr 15, 2019 at 05:23:53PM +0800, Mason Yang wrote:
> Patch Macronix MX25F0A SPI controller driver according to it's MFD driver.

It'd be much better to describe what the above actually means - what
changes have been made in the introduction of the MFD driver?  It does
feel like there's not as much abstraction as I'd expect between the MFD
and the child, there's a lot of peering into the parent and enabling and
disabling individual clocks for example rather than either having this
hidden behind a function or just having the clocks owned by the child
driver.  The driver also isn't using the MFD interfaces to pass through
the register subblocks for the IP - instead the child driver is peering
straight into the MFD structure and looking at a variable in there.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)