linux-kernel - Re: [PATCH 5.0 18/93] paride/pf: cleanup queues when detection fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190419133056.GC17719@sasha-vm>
Date:   Fri, 19 Apr 2019 09:30:56 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     nobuhiro1.iwamatsu@...hiba.co.jp
Cc:     gregkh@...uxfoundation.org, stable@...r.kernel.org,
        rdunlap@...radead.org, axboe@...nel.dk,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5.0 18/93] paride/pf: cleanup queues when detection fails

On Fri, Apr 19, 2019 at 07:13:40AM +0000, nobuhiro1.iwamatsu@...hiba.co.jp wrote:
>Hi,
>
>> [ Upstream commit 6ce59025f1182125e75c8d121daf44056b65dd1f ]
>>
>> The driver allocates queues for all the units it potentially
>> supports. But if we fail to detect any drives, then we fail
>> loading the module without cleaning up those queues. This is
>> now evident with the switch to blk-mq, though the bug has
>> been there forever as far as I can tell.
>>
>> Also fix cleanup through regular module exit.
>>
>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
>> Tested-by: Randy Dunlap <rdunlap@...radead.org>
>> Signed-off-by: Jens Axboe <axboe@...nel.dk>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>This commit causes a new problem. And the commit that made the fix
>is 58ccd2d31e502c37e108b285bf3d343eb00c235b.
>I think this commit needs to be applied together.

I've queued up this fix, thank you!

--
Thanks,
Sasha