linux-kernel - Re: [PATCH v2 0/2] staging: speakup: factor out selection code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190419131126.GA23752@kroah.com>
Date:   Fri, 19 Apr 2019 15:11:26 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Okash Khawaja <okash.khawaja@...il.com>
Cc:     Samuel Thibault <samuel.thibault@...-lyon.org>,
        Gregory Nowak <greg@...gn.net>, linux-kernel@...r.kernel.org,
        devel@...verdev.osuosl.org, Alan Cox <gnomes@...rguk.ukuu.org.uk>,
        Peter Hurley <peter@...leysoftware.com>,
        Kirk Reiser <kirk@...sers.ca>, speakup@...ux-speakup.org,
        Jiri Slaby <jslaby@...e.com>,
        John Covici <covici@....covici.com>,
        Ben Hutchings <ben@...adent.org.uk>,
        Chris Brannon <chris@...-brannons.com>
Subject: Re: [PATCH v2 0/2] staging: speakup: factor out selection code

On Wed, Apr 17, 2019 at 01:21:12PM +0100, Okash Khawaja wrote:
> Hi,
> 
> The v2 renames set_selection() and do_set_selection() to following 
> more explicit names:
> 
> set_selection_user() /* includes copying data from user space */
> set_selection_kernel() /* no copying from user space */
> 
> The patches also update references to set_selection() to be 
> set_selection_user().
> 
> Original intro:
> 
> Speakup's selection functionality parallels that of  
> drivers/tty/vt/selection.c. This patch set replaces speakup's
> implementation with calls to vt's selection code. This is one of the
> remaining items in our TODO file and it's needed for moving speakup out
> of staging.
> 
> Please note that in speakup selection is set inside interrupt context of
> keyboard handler. Set selection code in vt happens in process context
> and hence expects ability to sleep. To address this, there were two
> options: farm out speakup's set selection into a work_struct thread, or
> create atomic version of vt's set_selection. These patches implement
> the former option.

Very nice, both now queued up!

thanks,

greg k-h