linux-kernel - Re: [linux-sunxi] [PATCH] drm/sun4i: Unbind components before releasing DRM and mem at master unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fcd1b7b1b52e67e4f0a28fca567bf3243fe0ada.camel@bootlin.com>
Date:   Fri, 19 Apr 2019 19:10:53 +0200
From:   Paul Kocialkowski <paul.kocialkowski@...tlin.com>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-sunxi <linux-sunxi@...glegroups.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [linux-sunxi] [PATCH] drm/sun4i: Unbind components before
 releasing DRM and mem at master unbind

Hi,

On Fri, 2019-04-19 at 09:02 -0700, Chen-Yu Tsai wrote:
> On Fri, Apr 19, 2019 at 1:03 AM Paul Kocialkowski
> <paul.kocialkowski@...tlin.com> wrote:
> > Our components may still be using the DRM device driver (if only to
> > access our driver's private data), so make sure to unbind them before
> > the final drm_dev_put.
> > 
> > Also release our resserved memory adter unbind to match reverse
> 
> typos...

I'll probably spin up a v2 to fix them, they annoy me as well.

> > creation order.
> > 
> > Fixes: f5a9ed867c83 ("drm/sun4i: Fix component unbinding and component master deletion")
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> > ---
> >  drivers/gpu/drm/sun4i/sun4i_drv.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
> > index 843b86661833..29258b404e54 100644
> > --- a/drivers/gpu/drm/sun4i/sun4i_drv.c
> > +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
> > @@ -149,10 +149,11 @@ static void sun4i_drv_unbind(struct device *dev)
> >         drm_kms_helper_poll_fini(drm);
> >         drm_atomic_helper_shutdown(drm);
> >         drm_mode_config_cleanup(drm);
> > -       of_reserved_mem_device_release(dev);
> > -       drm_dev_put(drm);
> > 
> >         component_unbind_all(dev, NULL);
> > +       of_reserved_mem_device_release(dev);
> 
> You should probably mention this change in the commit log as well.

That's what I meant with the line that has typos. Maybe I should make
it slightly more explicit as:

Also released our reserved memory after component unbind instead of
before to match reverse creation order.

What do you think?

> Otherwise,
> 
> Reviewed-by: Chen-Yu Tsai <wens@...e.org>

Thanks for the review!

Cheers,

Paul

> > +
> > +       drm_dev_put(drm);
> >  }
> > 
> >  static const struct component_master_ops sun4i_drv_master_ops = {
> > --
> > 2.21.0
> > 
> > --
> > You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@...glegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com