linux-kernel - Re: net: ax25: %x specifier misuse in kernel?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b376d2b-9fdb-9043-5bc6-48fb2e4cb821@gmail.com>
Date:   Thu, 18 Apr 2019 20:02:30 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     PlusOneSecond <plusonesecond@...mail.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: net: ax25: %x specifier misuse in kernel?



On 04/18/2019 07:01 PM, PlusOneSecond wrote:
> In ax25_info_show of af_ax25.c:1891, linux-5.1.
> The pointer ax25 is cast to long type to print out.
> 
> Why it prints the a pointer 'ax25' use %8.8lx rather than %p?
> If it really want to print the value of ax25, it should use %px.

I guess nobody cared enough abut this security issue.

Please send a patch, thanks.

> 
> Also, I  scan the kernel code and notice that most of the pointers cast to long or unsigned long type to print out are marked with __iomem.
> Is it a misuse of %x?
> 
> 
> Thanks.
>