linux-kernel - Re: [PATCH v3 4/4] samples: show race-free pidfd metadata access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190419153047.GA12228@redhat.com>
Date:   Fri, 19 Apr 2019 17:30:48 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Christian Brauner <christian@...uner.io>
Cc:     torvalds@...ux-foundation.org, viro@...iv.linux.org.uk,
        jannh@...gle.com, dhowells@...hat.com, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org, serge@...lyn.com, luto@...nel.org,
        arnd@...db.de, ebiederm@...ssion.com, keescook@...omium.org,
        tglx@...utronix.de, mtk.manpages@...il.com,
        akpm@...ux-foundation.org, cyphar@...har.com,
        joel@...lfernandes.org, dancol@...gle.com,
        Jann Horn <jann@...jh.net>
Subject: Re: [PATCH v3 4/4] samples: show race-free pidfd metadata access

On 04/19, Christian Brauner wrote:
>
> +int main(int argc, char *argv[])
> +{
> +	int ret = EXIT_FAILURE;
> +	char buf[4096] = { 0 };
> +	pid_t pid;
> +	int pidfd, procfd, statusfd;

I think you need to initialize pidfd = 0 in this version ;) Otherwise,

Reviewed-by: Oleg Nesterov <oleg@...hat.com>