linux-kernel - Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190419135830.0e3273e223fb83947e5adb0d@linux-foundation.org>
Date:   Fri, 19 Apr 2019 13:58:30 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Douglas Anderson <dianders@...omium.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jason Wessel <jason.wessel@...driver.com>,
        Christophe Leroy <christophe.leroy@....fr>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        kgdb-bugreport@...ts.sourceforge.net,
        Johannes Weiner <hannes@...xchg.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Nicholas Mc Guire <hofrat@...dl.org>
Subject: Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in
 kdb summary

On Fri, 19 Apr 2019 04:14:27 -0700 Joe Perches <joe@...ches.com> wrote:

> On Fri, 2019-04-19 at 12:28 +0900, Masahiro Yamada wrote:
> > Hi Joe,
> > 
> > Can you detect redundant Cc: by checkpatch?
> > 
> > Please see below in details.
> > Thanks.
> 
> Yes, but I'm not sure why it's useful or necessary.
> git send-email using some scripts elides duplicate email addresses

Other (all?) MUAs will avoid addressing an email to a recipient more
than once.  The issue here is redundant Cc: lines in the changelog.

> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2688,6 +2688,19 @@ sub process {
>  				$signatures{$sig_nospace} = 1;
>  			}
>  
> +# Check for a cc: line with another signature -by: by the same author
> +			if ($sig_nospace =~ /^cc:/) {
> +				my $sig_email = substr($sig_nospace, 3);
> +				foreach my $sig (sort keys %signatures) {
> +					next if ($sig =~ /^cc:/);
> +					$sig =~ s/^[^:]+://;
> +					if ($sig eq $sig_email) {
> +						WARN("BAD_SIGN_OFF",
> +						     "Unnecessary CC: as there is another signature with the same name/email address\n" . $herecurr);
> +					}
> +				}
> +			}
> +
>  # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email
>  			if ($sign_off =~ /^co-developed-by:$/i) {
>  				if ($email eq $author) {

Thanks.  But my checkpatch.pl is different from yours.

q:/usr/src/25> grep "immediately followed by" scripts/checkpatch.pl
q:/usr/src/25>