linux-kernel - Re: [PATCH net-next] net: mvpp2: cls: Add Classification offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190420121714.387f160b@bootlin.com>
Date:   Sat, 20 Apr 2019 12:17:14 +0200
From:   Maxime Chevallier <maxime.chevallier@...tlin.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        antoine.tenart@...tlin.com, thomas.petazzoni@...tlin.com,
        gregory.clement@...tlin.com, miquel.raynal@...tlin.com,
        nadavh@...vell.com, stefanc@...vell.com, mw@...ihalf.com,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next] net: mvpp2: cls: Add Classification offload
 support

Hi David,

On Fri, 19 Apr 2019 15:09:50 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

>From: Maxime Chevallier <maxime.chevallier@...tlin.com>
>Date: Fri, 19 Apr 2019 15:30:27 +0200
>
>> +/* Internal represention of a Flow Steering rule */
>> +struct mvpp2_rfs_rule {
>> +	/* Rule location inside the flow*/
>> +	int loc;
>> +
>> +	/* Flow type, such as TCP_V4_FLOW, IP6_FLOW, etc. */
>> +	int flow_type;
>> +
>> +	/* The lookup type used by this flow. This allows the classification
>> +	 * engines to differentiate between entries that match the same
>> +	 * parameters
>> +	 */
>> +	int lu_type;
>> +
>> +	/* Index of the entry handling this rule in the flow table */
>> +	int flt_index;
>> +
>> +	/* Index of the C2 TCAM entry handling this rule */
>> +	int c2_index;  
>
>On 64-bit there will be a 32-bit hole here.  Why not put hek_fields
>and engine here?

You're right, I'll re-arrange that.

Thanks,

Maxime