lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 22 Apr 2019 00:18:56 +1000 (AEST)
From:   Michael Ellerman <>
To:     Peng Hao <>,,,,
Cc:, Wen Yang <>,
Subject: Re: [v3] powerpc/8xx: fix possible object reference leak

On Tue, 2019-03-26 at 10:29:51 UTC, Peng Hao wrote:
> From: Wen Yang <>
> The call to of_find_compatible_node returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
> irq_domain_add_linear also calls of_node_get to increase refcount,
> so irq_domain will not be affected when it is released.
> Detected by coccinelle with the following warnings:
> ./arch/powerpc/platforms/8xx/pic.c:158:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 136, but without a corresponding object release within this function.
> Fixes: a8db8cf0d894 ("irq_domain: Replace irq_alloc_host() with
> revmap-specific initializers")
> Signed-off-by: Wen Yang <>
> Suggested-by: Christophe Leroy <>
> Suggested-by: Michael Ellerman <>
> Reviewed-by: Peng Hao <>
> Reviewed-by: Christophe Leroy <>
> Cc: Vitaly Bordug <>
> Cc: Benjamin Herrenschmidt <>
> Cc: Paul Mackerras <>
> Cc: Michael Ellerman <>
> Cc:
> Cc:

Applied to powerpc next, thanks.


Powered by blists - more mailing lists