lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <44nBf84YyCz9sB3@ozlabs.org> Date: Mon, 22 Apr 2019 00:18:56 +1000 (AEST) From: Michael Ellerman <patch-notifications@...erman.id.au> To: Peng Hao <peng.hao2@....com.cn>, vitb@...nel.crashing.org, benh@...nel.crashing.org, paulus@...ba.org, christophe.leroy@....fr Cc: linuxppc-dev@...ts.ozlabs.org, Wen Yang <wen.yang99@....com.cn>, linux-kernel@...r.kernel.org Subject: Re: [v3] powerpc/8xx: fix possible object reference leak On Tue, 2019-03-26 at 10:29:51 UTC, Peng Hao wrote: > From: Wen Yang <wen.yang99@....com.cn> > > The call to of_find_compatible_node returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > irq_domain_add_linear also calls of_node_get to increase refcount, > so irq_domain will not be affected when it is released. > > Detected by coccinelle with the following warnings: > ./arch/powerpc/platforms/8xx/pic.c:158:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 136, but without a corresponding object release within this function. > > Fixes: a8db8cf0d894 ("irq_domain: Replace irq_alloc_host() with > revmap-specific initializers") > Signed-off-by: Wen Yang <wen.yang99@....com.cn> > Suggested-by: Christophe Leroy <christophe.leroy@....fr> > Suggested-by: Michael Ellerman <mpe@...erman.id.au> > Reviewed-by: Peng Hao <peng.hao2@....com.cn> > Reviewed-by: Christophe Leroy <christophe.leroy@....fr> > Cc: Vitaly Bordug <vitb@...nel.crashing.org> > Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org> > Cc: Paul Mackerras <paulus@...ba.org> > Cc: Michael Ellerman <mpe@...erman.id.au> > Cc: linuxppc-dev@...ts.ozlabs.org > Cc: linux-kernel@...r.kernel.org Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/cc76404feaed597bb4f5234d34d3f49e cheers
Powered by blists - more mailing lists