linux-kernel - Re: [PATCH] iio: adc: qcom-spmi-adc5: Fix of-based module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190422115412.4e2f717a@archlinux>
Date:   Mon, 22 Apr 2019 11:54:12 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] iio: adc: qcom-spmi-adc5: Fix of-based module
 autoloading

On Tue, 16 Apr 2019 16:49:27 -0700
Bjorn Andersson <bjorn.andersson@...aro.org> wrote:

> The of_device_id table needs to be registered as module alias in order
> for automatic module loading to pick the kernel module based on the
> DeviceTree compatible. So add MODULE_DEVICE_TABLE() to make this happen.
> 
> Fixes: e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
I'll take this via the next merge window because it's been there a little
while and in isn't a regression.  Obviously we are very late in this
cycle so I'd rather not do another fixes pull request.

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/qcom-spmi-adc5.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
> index 6a866cc187f7..21fdcde77883 100644
> --- a/drivers/iio/adc/qcom-spmi-adc5.c
> +++ b/drivers/iio/adc/qcom-spmi-adc5.c
> @@ -664,6 +664,7 @@ static const struct of_device_id adc5_match_table[] = {
>  	},
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, adc5_match_table);
>  
>  static int adc5_get_dt_data(struct adc5_chip *adc, struct device_node *node)
>  {