linux-kernel - Re: [PATCH] reiserfs: Force type conversion in xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190422122705.9df141f5c9b4e842e170e72a@linux-foundation.org>
Date:   Mon, 22 Apr 2019 12:27:05 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Bharath Vedartham <linux.bhar@...il.com>, jannh@...gle.com,
        reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reiserfs: Force type conversion in xattr_hash

On Sun, 21 Apr 2019 18:02:35 +0100 Al Viro <viro@...iv.linux.org.uk> wrote:

> IOW, what sparse has caught here is a genuine endianness bug; images
> created on little-endian host and mounted on big-endian (or vice
> versa) will see csum mismatches when trying to fetch xattrs.

OK, thanks.  I'll drop the patch - we shouldn't hide that reminder of a
bug.

Perhaps someone could prepare a patch which adds a comment explaining
these issues, so someone else doesn't try to "fix" the sparse warning.