linux-kernel - Re: [PATCH 4.19 13/99] netfilter: nf_conncount: fix argument order to find_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190422194053.k6h4cunlfpjlt5wk@breakpoint.cc>
Date:   Mon, 22 Apr 2019 21:40:53 +0200
From:   Florian Westphal <fw@...len.de>
To:     Andreas Hartmann <andihartmann@...enet.de>
Cc:     Florian Westphal <fw@...len.de>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4.19 13/99] netfilter: nf_conncount: fix argument order
 to find_next_bit

Andreas Hartmann <andihartmann@...enet.de> wrote:
> On 22.04.19 at 20:57 Florian Westphal wrote:
> > grep CONNCOUNT ~/your_kernel_conf
> 
> True - it's not in use (it's not even configured) at all. I'm surprised that it seems to fix the problem anyway.

Thats usually the main problem when testing for a bug that doesn't
appear often -- its too easy to get bisections wrong and end up
with false positives.

> If I can't see it any more - I wouldn't know what to do any further at the moment.

You could try enabling some of the debug features, such as
CONFIG_PROVE_{LOCKING,RCU}.

It would e.g. tell if we forget an unlock somewhere.