linux-kernel - [PATCH v2 1/1] r8152: sync sa_family with the media type of network device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190422050344.24513-1-crag0715@gmail.com>
Date:   Mon, 22 Apr 2019 13:03:43 +0800
From:   crag0715@...il.com
To:     linux-usb@...r.kernel.org, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, hayeswang@...ltek.com,
        mario_limonciello@...l.com, crag0715@...il.com,
        "Crag.Wang" <crag.wang@...l.com>,
        "David S. Miller" <davem@...emloft.net>,
        Simon Glass <sjg@...omium.org>,
        Grant Grundler <grundler@...omium.org>,
        Sean Paul <seanpaul@...omium.org>,
        David Chen <david.chen7@...l.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Charles Hyde <charles.hyde@...l.corp-partner.google.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        zhong jiang <zhongjiang@...wei.com>
Subject: [PATCH v2 1/1] r8152: sync sa_family with the media type of network device

From: "Crag.Wang" <crag.wang@...l.com>

Without this patch the socket address family sporadically gets wrong
value ends up the dev_set_mac_address() fails to set the desired MAC
address.

Signed-off-by: Crag.Wang <crag.wang@...l.com>
---
 drivers/net/usb/r8152.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 4c63b40d5e00..41fb39ce69c9 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa)
 	struct net_device *dev = tp->netdev;
 	int ret;
 
+	sa->sa_family = dev->type;
+
 	if (tp->version == RTL_VER_01) {
 		ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data);
 	} else {
-- 
2.20.1