linux-kernel - Re: [PATCH AUTOSEL 5.0 70/98] tty: fix NULL pointer issue when tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190422204002.GA5474@kroah.com>
Date:   Mon, 22 Apr 2019 22:40:02 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Fabien Dessenne <fabien.dessenne@...com>
Subject: Re: [PATCH AUTOSEL 5.0 70/98] tty: fix NULL pointer issue when
 tty_port ops is not set

On Mon, Apr 22, 2019 at 03:41:37PM -0400, Sasha Levin wrote:
> From: Fabien Dessenne <fabien.dessenne@...com>
> 
> [ Upstream commit f4e68d58cf2b20a581759bbc7228052534652673 ]
> 
> Unlike 'client_ops' which is initialized to 'default_client_ops', the
> port operations 'ops' may be left to NULL.
> Check the 'ops' value before checking the 'ops->x' value.
> 
> Signed-off-by: Fabien Dessenne <fabien.dessenne@...com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Sasha Levin (Microsoft) <sashal@...nel.org>
> ---
>  drivers/tty/tty_port.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Nope, I have a revert for this in my tree for 5.2-rc1, no need for this
in any stable tree, it doesn't do anything :)

Please drop it from all branches, thanks.

greg k-h