linux-kernel - Re: [PATCH v1 1/3] PCI / ACPI: Do not export pci_get_hp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b2b2396-b60b-ad25-d4ab-e3633fd93d0c@gmail.com>
Date:   Mon, 22 Apr 2019 18:45:27 -0500
From:   Alex G <mr.nuke.me@...il.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     austin_bolen@...l.com, alex_gagniuc@...lteam.com,
        keith.busch@...el.com, Shyam_Iyer@...l.com, lukas@...ner.de,
        okaya@...nel.org, "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] PCI / ACPI: Do not export pci_get_hp_params()

On 4/22/19 3:58 PM, Bjorn Helgaas wrote:
> On Fri, Feb 08, 2019 at 10:24:11AM -0600, Alexandru Gagniuc wrote:
>> This is only used within drivers/pci, and there is no reason to make
>> it available outside of the PCI core.
>>
>> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@...il.com>
> 
> Applied the whole series to pci/hotplug for v5.2, thanks!
> 
> I dropped the "list" member from struct hpx_type3 because it didn't
> seem to be used.

That's a good call. That was a vestigial appendage from when I first 
intended to store a list of registers in memory. I'm glad we didn't end 
up needing a list.

Alex