linux-kernel - Re: [PATCH] crypto: ecrdsa - select ASN1 and OID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Apr 2019 13:20:30 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Vitaly Chikunov <vt@...linux.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA

On 4/23/19 9:29 AM, Vitaly Chikunov wrote:
> Fix undefined symbol issue in ecrdsa_generic module when ASN1
> or OID_REGISTRY aren't enabled in the config by selecting these
> options for CRYPTO_ECRDSA.
> 
> ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
> ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Vitaly Chikunov <vt@...linux.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

My tools would prefer to see the diff at one tree level higher:


> ---
>  crypto/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git crypto/Kconfig crypto/Kconfig

  diff --git a/crypto/Kconfig b/crypto/Kconfig

for any spelling of a and b.


> index 4446833f6eca..3d056e7da65f 100644
> --- crypto/Kconfig
> +++ crypto/Kconfig

  --- a/crypto/Kconfig
  +++ b/crypto/Kconfig

> @@ -264,6 +264,8 @@ config CRYPTO_ECRDSA
>  	select CRYPTO_ECC
>  	select CRYPTO_AKCIPHER
>  	select CRYPTO_STREEBOG
> +	select OID_REGISTRY
> +	select ASN1
>  	help
>  	  Elliptic Curve Russian Digital Signature Algorithm (GOST R 34.10-2012,
>  	  RFC 7091, ISO/IEC 14888-3:2018) is one of the Russian cryptographic
> 


-- 
~Randy