linux-kernel - [PATCH] sh: require --Wl,--hash-style=sysv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190423202907.234180-1-ndesaulniers@google.com>
Date:   Tue, 23 Apr 2019 13:29:05 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     ysato@...rs.sourceforge.jp, dalias@...c.org
Cc:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Andy Lutomirsky <luto@...nel.org>,
        clang-built-linux@...glegroups.com,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] sh: require --Wl,--hash-style=sysv

Towards the goal of removing cc-ldoption, prefer ld-option, or better
yet, require --Wl,--hash-style=sysv since the selftest for vdso's
requires DT_HASH.

Cc: Andy Lutomirsky <luto@...nel.org>
Cc: clang-built-linux@...glegroups.com
Suggested-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
---
 arch/sh/kernel/vsyscall/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile
index 5db6579bc44c..6e8664448048 100644
--- a/arch/sh/kernel/vsyscall/Makefile
+++ b/arch/sh/kernel/vsyscall/Makefile
@@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
 
 export CPPFLAGS_vsyscall.lds += -P -C -Ush
 
-vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
-		$(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
+vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
 
 SYSCFLAGS_vsyscall-trapa.so	= $(vsyscall-flags)
 
-- 
2.21.0.593.g511ec345e18-goog