linux-kernel - Re: [PATCH 1/2] seccomp: fix up grammar in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJDhQ_3jS9-VSUwruFDpb4GwqUs=iz7uNGMkPbLnNWKUw@mail.gmail.com>
Date:   Tue, 23 Apr 2019 15:11:03 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Tycho Andersen <tycho@...ho.ws>, James Morris <jmorris@...ei.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] seccomp: fix up grammar in comment

On Wed, Mar 6, 2019 at 12:14 PM Tycho Andersen <tycho@...ho.ws> wrote:
>
> This sentence is kind of a train wreck anyway, but at least dropping the
> extra pronoun helps somewhat.
>
> Signed-off-by: Tycho Andersen <tycho@...ho.ws>

Acked-by: Kees Cook <keescook@...omium.org>

James, this can go in for v5.2 -- no rush.

-Kees

> ---
>  kernel/seccomp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/seccomp.c b/kernel/seccomp.c
> index e815781ed751..d0d355ded2f4 100644
> --- a/kernel/seccomp.c
> +++ b/kernel/seccomp.c
> @@ -329,7 +329,7 @@ static int is_ancestor(struct seccomp_filter *parent,
>   * Expects sighand and cred_guard_mutex locks to be held.
>   *
>   * Returns 0 on success, -ve on error, or the pid of a thread which was
> - * either not in the correct seccomp mode or it did not have an ancestral
> + * either not in the correct seccomp mode or did not have an ancestral
>   * seccomp filter.
>   */
>  static inline pid_t seccomp_can_sync_threads(void)
> --
> 2.19.1
>


-- 
Kees Cook