linux-kernel - Re: [PATCH v3 2/2] clk:mmp: clk-mix.c fix divide-by-zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Apr 2019 16:00:27 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     chao.xie@...vell.com, jbrunet@...libre.com, mojha@...eaurora.org,
        mturquette@...libre.com, nixiaoming@...wei.com,
        sboyd@...eaurora.org, soren.brinkmann@...inx.com
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] clk:mmp: clk-mix.c fix divide-by-zero

Quoting nixiaoming (2019-03-30 06:55:42)
> The _get_div() function has a branch with a return value of 0
> Add a check on the return value of _get_div() to avoid divide-by-zero
> 

Are you seeing this in practice? Or just trying to avoid a div-by-zero
case that you've found from inspection? 

> Signed-off-by: nixiaoming <nixiaoming@...wei.com>
> Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>