linux-kernel - Re: [PATCH v3 0/3] Add runtime PM for SAI digital audio interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1556004028.2595.2.camel@nxp.com>
Date:   Tue, 23 Apr 2019 07:20:28 +0000
From:   Viorel Suman <viorel.suman@....com>
To:     Daniel Baluta <daniel.baluta@....com>,
        "broonie@...nel.org" <broonie@...nel.org>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "timur@...nel.org" <timur@...nel.org>,
        "Xiubo.Lee@...il.com" <Xiubo.Lee@...il.com>,
        "festevam@...il.com" <festevam@...il.com>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "S.j. Wang" <shengjiu.wang@....com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH v3 0/3] Add runtime PM for SAI digital audio interface

For this series:

Reviewed-by: Viorel Suman <viorel.suman@....com>

On Lu, 2019-04-22 at 19:02 +0000, Daniel Baluta wrote:
> First patch fixes a bug by correctly setting is_slave_mode, then
> second patch adds support for runtime PM and finally 3rd patch moves
> clock handling from startup/shtudown function to runtime PM handlers.
> 
> Changes since v2: (after Viorel's comments)
> 	- no need to check for is_slave_mode when enabling/disabling the clocks
> 	because sai->mclk_streams is only set when SAI is in master mode.
> 
> Changes since v1: (after Nicolin's comments)
> 	- added patch 1
> 	- added fsl_sai_remove in order to call pm_runtime_disable
> 	- only disable/enable mclk when SAI in master mode.
> 
> Daniel Baluta (2):
>   ASoC: fsl_sai: Update is_slave_mode with correct value
>   ASoC: fsl_sai: Add support for runtime pm
> 
> Shengjiu Wang (1):
>   ASoC: fsl_sai: Move clock operation to PM runtime
> 
>  sound/soc/fsl/fsl_sai.c | 78 +++++++++++++++++++++++++++++++++--------
>  1 file changed, 63 insertions(+), 15 deletions(-)
> 
> -- 
> 2.17.1
>