linux-kernel - Re: [PATCH v2 03/06] misc: genwqe: Fix misuse of %x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Apr 2019 09:55:51 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     Frank Haverkamp <haver@...ux.ibm.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 03/06] misc: genwqe: Fix misuse of %x

On Sun, Apr 21, 2019 at 1:48 PM Fuqian Huang <huangfq.daxian@...il.com> wrote:
>
> The pointer should be printed with %p or %px rather than
> cast to long long type and printed with %016llx.
> Change %x to %p to print the pointer.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>

I would recommend to also use %pad for printing dma_addr_t if you do this.

      Arnd