linux-kernel - Re: [PATCH] rcu/tree_exp: cleanup initialized but not used rdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Apr 2019 01:06:44 -0700
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     Jiang Biao <benbjiang@...cent.com>
Cc:     josh@...htriplett.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu/tree_exp: cleanup initialized but not used rdp

On Tue, Apr 23, 2019 at 09:21:55AM +0800, Jiang Biao wrote:
> rdp is initialized but never used in synchronize_rcu_expedited(),
> just remove it.
> 
> Signed-off-by: Jiang Biao <benbjiang@...cent.com>

I queued and pushed both patches for testing and review, good eyes,
thank you!  I reworded the subject and commit logs, so could you please
check to make sure that I didn't mess anything up?

							Thanx, Paul

> ---
>  kernel/rcu/tree_exp.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
> index 4c2a0189e748..5772612379e4 100644
> --- a/kernel/rcu/tree_exp.h
> +++ b/kernel/rcu/tree_exp.h
> @@ -733,7 +733,6 @@ static void sync_sched_exp_online_cleanup(int cpu)
>   */
>  void synchronize_rcu_expedited(void)
>  {
> -	struct rcu_data *rdp;
>  	struct rcu_exp_work rew;
>  	struct rcu_node *rnp;
>  	unsigned long s;
> @@ -770,7 +769,6 @@ void synchronize_rcu_expedited(void)
>  	}
>  
>  	/* Wait for expedited grace period to complete. */
> -	rdp = per_cpu_ptr(&rcu_data, raw_smp_processor_id());
>  	rnp = rcu_get_root();
>  	wait_event(rnp->exp_wq[rcu_seq_ctr(s) & 0x3],
>  		   sync_exp_work_done(s));
> -- 
> 2.17.2 (Apple Git-113)
>