linux-kernel - Re: [PATCH 1/3] arm64: dts: meson-g12a: Add IR nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48194bd4-1928-3941-aef9-8f7d1fb9a9d1@baylibre.com>
Date:   Tue, 23 Apr 2019 10:30:31 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     khilman@...libre.com, baylibre-upstreaming@...ups.io,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] arm64: dts: meson-g12a: Add IR nodes

Hi Martin,

On 13/04/2019 14:02, Martin Blumenstingl wrote:
> Hi Neil,
> 
> On Fri, Apr 12, 2019 at 12:05 PM Neil Armstrong <narmstrong@...libre.com> wrote:
>>
>> Amlogic G12A SoCs uses the exact same IR decoder as previous
>> families, add the IR node and the pintctrl setting.
> as far as I can tell there are either two IR decoders or one updated
> IR decoder in G12A and G12B.
> I'm using mesong12a.dtsi from
> buildroot_openlinux_kernel_4.9_fbdev_20180706 as reference:
>   remote:rc@...f808040 {
>       compatible = "amlogic, aml_remote";
>       reg = <0x0 0xff808040 0x00 0x44>, /*Multi-format IR controller*/
>                 <0x0 0xff808000 0x00 0x20>; /*Legacy IR controller*/
>       ...
> 
> the registers which you are mapping are for the "Legacy IR
> controller", so our existing meson-ir driver will probably work (I
> haven't tested it myself yet).

We use only the "legacy IR decoder" since GXBB, we never had a driver for
the "Multi-format IR controller".

> 
> can you please be explicit about this in the patch description?

Sure

> 
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> apart from the description you can add my:
> Reviewed-by: Martin Blumenstingl<martin.blumenstingl@...glemail.com>
> 

Thanks,
Neil