linux-kernel - Re: [PATCH v2 05/36] coresight: tmc: Cleanup power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <204642c0-e83e-9a46-12f2-8b17e6ff8467@arm.com>
Date:   Tue, 23 Apr 2019 10:33:38 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     mathieu.poirier@...aro.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        coresight@...ts.linaro.org, mike.leach@...aro.org,
        rjw@...ysocki.net, robert.walker@....com
Subject: Re: [PATCH v2 05/36] coresight: tmc: Cleanup power management

On 04/17/2019 09:03 PM, Mathieu Poirier wrote:
> On Mon, 15 Apr 2019 at 10:05, Suzuki K Poulose <suzuki.poulose@....com> wrote:
>>
>> Drop the power only if we were successful in probing the device.
>>
>> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
>> ---
>>   drivers/hwtracing/coresight/coresight-tmc.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
>> index 647b6aa..c6a5462 100644
>> --- a/drivers/hwtracing/coresight/coresight-tmc.c
>> +++ b/drivers/hwtracing/coresight/coresight-tmc.c
>> @@ -432,8 +432,6 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id)
>>                  drvdata->size = readl_relaxed(drvdata->base + TMC_RSZ) * 4;
>>          }
>>
>> -       pm_runtime_put(&adev->dev);
>> -
>>          desc.pdata = pdata;
>>          desc.dev = dev;
>>          desc.groups = coresight_tmc_groups;
>> @@ -476,6 +474,8 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id)
>>          ret = misc_register(&drvdata->miscdev);
>>          if (ret)
>>                  coresight_unregister(drvdata->csdev);
>> +       else
>> +               pm_runtime_put(&adev->dev);
>>   out:
>>          return ret;
>>   }
> 
> I have applied patches 1 to 5.

Thanks Mathieu !