linux-kernel - Re: [PATCH] kvm_main: fix some comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190423131153.4b68c9e6.cohuck@redhat.com>
Date:   Tue, 23 Apr 2019 13:11:53 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     Jiang Biao <benbjiang@...cent.com>
Cc:     <pbonzini@...hat.com>, <rkrcmar@...hat.com>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kvm_main: fix some comments

On Tue, 23 Apr 2019 17:40:08 +0800
Jiang Biao <benbjiang@...cent.com> wrote:

> is_dirty has been rename to flush, but the comment for it is

s/rename/renamed/

> outdated. And the description about @flush parameter for
> kvm_clear_dirty_log_protect() is missing, add it in this patch
> also.
> 
> Signed-off-by: Jiang Biao <benbjiang@...cent.com>
> ---
>  virt/kvm/kvm_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index dc8edc97ba85..40b435e77672 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1138,7 +1138,7 @@ EXPORT_SYMBOL_GPL(kvm_get_dirty_log);
>   *	and reenable dirty page tracking for the corresponding pages.

BTW: Not seen in the diff, but this line and the preceding one do not
really form a sentence that makes sense :) Maybe fix that as well, as
you are touching the area anyway?

>   * @kvm:	pointer to kvm instance
>   * @log:	slot id and address to which we copy the log
> - * @is_dirty:	flag set if any page is dirty
> + * @flush:	if TLB flush is needed by caller

Hm, maybe "true if TLB flush is needed by caller"?

>   *
>   * We need to keep it in mind that VCPU threads can write to the bitmap
>   * concurrently. So, to avoid losing track of dirty pages we keep the
> @@ -1223,6 +1223,7 @@ EXPORT_SYMBOL_GPL(kvm_get_dirty_log_protect);
>   *	and reenable dirty page tracking for the corresponding pages.
>   * @kvm:	pointer to kvm instance
>   * @log:	slot id and address from which to fetch the bitmap of dirty pages
> + * @flush:	if TLB flush is needed by caller
>   */
>  int kvm_clear_dirty_log_protect(struct kvm *kvm,
>  				struct kvm_clear_dirty_log *log, bool *flush)