linux-kernel - Re: [PATCH v2 1/2] xen/pvh: set xen_domain_type to HVM in xen_pvh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2e1612e-d6c2-ba46-b49e-4e0fe95a1d7e@oracle.com>
Date:   Tue, 23 Apr 2019 09:37:51 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Roger Pau Monne <roger.pau@...rix.com>,
        linux-kernel@...r.kernel.org
Cc:     Juergen Gross <jgross@...e.com>, xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v2 1/2] xen/pvh: set xen_domain_type to HVM in
 xen_pvh_init

On 4/23/19 9:04 AM, Roger Pau Monne wrote:
> Or else xen_domain() returns false despite xen_pvh being set.

Is this new xen_domain() invocation somewhere in EFI initialization that
you add in the second patch?

Asking because I am trying to figure out whether this needs to go to
stable tree.

-boris

>
> Signed-off-by: Roger Pau Monné <roger.pau@...rix.com>
> ---
> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> Cc: Juergen Gross <jgross@...e.com>
> Cc: xen-devel@...ts.xenproject.org
> ---
>  arch/x86/xen/enlighten_pvh.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c
> index 35b7599d2d0b..bbffa409e0e8 100644
> --- a/arch/x86/xen/enlighten_pvh.c
> +++ b/arch/x86/xen/enlighten_pvh.c
> @@ -27,6 +27,7 @@ void __init xen_pvh_init(void)
>  	u64 pfn;
>  
>  	xen_pvh = 1;
> +	xen_domain_type = XEN_HVM_DOMAIN;
>  	xen_start_flags = pvh_start_info.flags;
>  
>  	msr = cpuid_ebx(xen_cpuid_base() + 2);