linux-kernel - Re: [PATCH v3] signal: trace_signal_deliver when signal_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <AF4D908CC0E2A24EB308A26962C8C3BDEB16D1@DGGEMI530-MBX.china.huawei.com>
Date:   Tue, 23 Apr 2019 14:02:21 +0000
From:   weizhenliang <weizhenliang@...wei.com>
To:     Christian Brauner <christian@...uner.io>
CC:     Oleg Nesterov <oleg@...hat.com>,
        "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "colona@...sta.com" <colona@...sta.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "deepa.kernel@...il.com" <deepa.kernel@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit

On Tue, Apr 23, 2019 at 09:41 PM Christian wrote:
>On Tue, Apr 23, 2019 at 01:10:52PM +0000, weizhenliang wrote:
>> On Mon, Apr 22, 2019 at 11:25 PM Oleg Nesterov <oleg@...hat.com> wrote:
>> >On 04/22, Zhenliang Wei wrote:
>> >>
>> >> --- a/kernel/signal.c
>> >> +++ b/kernel/signal.c
>> >> @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig)
>> >>  	if (signal_group_exit(signal)) {
>> >>  		ksig->info.si_signo = signr = SIGKILL;
>> >>  		sigdelset(&current->pending.signal, SIGKILL);
>> >> +		trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL);
>> >>  		recalc_sigpending();
>> >>  		goto fatal;
>> >>  	}
>> >
>> >Reviewed-by: Oleg Nesterov <oleg@...hat.com>
>> 
>> Last time Oleg suggested using SIG_DFL as the third parameter, but its type is 'void (*)(int)', but not expected 'struct k_sigaction *'.
>
>Sigh, I should've caught that in the first commit.
>Although it suggests you didn't even compile your patch...
>
>> 
>> How about
>> 	trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, &sighand->action[signr 
>> - 1]); ?
>
>That should work, yes.

Sorry about that, I was too focused on the functionality and didn't notice the compile warning.
And thanks for your reply, I will pay more attention to it in the future.

Zhenliang Wei