linux-kernel - Re: [PATCH] drm/sched: Fix description of drm_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c7c1779-2617-58be-83c5-5145b0edd7fa@amd.com>
Date:   Tue, 23 Apr 2019 14:17:47 +0000
From:   "Grodzovsky, Andrey" <Andrey.Grodzovsky@....com>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
CC:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        Nayan Deshmukh <nayan26deshmukh@...il.com>,
        Eric Anholt <eric@...olt.net>, Pixel Ding <Pixel.Ding@....com>,
        Sharat Masetty <smasetty@...eaurora.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/sched: Fix description of drm_sched_stop

Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@....com>

Andrey

On 4/20/19 8:50 AM, Jonathan Neuschäfer wrote:
> Since commit 222b5f044159 ("drm/sched: Refactor ring mirror list
> handling."), drm_sched_hw_job_reset is no longer there, so let's adjust
> the doc comment accordingly.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> ---
>   drivers/gpu/drm/scheduler/sched_main.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 19fc601c9eeb..a1bec2779e76 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -366,10 +366,9 @@ void drm_sched_increase_karma(struct drm_sched_job *bad)
>   EXPORT_SYMBOL(drm_sched_increase_karma);
>
>   /**
> - * drm_sched_hw_job_reset - stop the scheduler if it contains the bad job
> + * drm_sched_stop - stop the scheduler
>    *
>    * @sched: scheduler instance
> - * @bad: bad scheduler job
>    *
>    */
>   void drm_sched_stop(struct drm_gpu_scheduler *sched)
> --
> 2.20.1
>