linux-kernel - Re: [PATCH v2 06/06] sound: isa: gus: fix misuse of %x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h36m8g5ps.wl-tiwai@suse.de>
Date:   Tue, 23 Apr 2019 16:24:15 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Fuqian Huang" <huangfq.daxian@...il.com>
Cc:     <alsa-devel@...a-project.org>, "Jaroslav Kysela" <perex@...ex.cz>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 06/06] sound: isa: gus: fix misuse of %x

On Sun, 21 Apr 2019 13:48:44 +0200,
Fuqian Huang wrote:
> 
> Pointers should be printed with %p or %px rather than
> cast to long type and printed with %lx.
> Change %lx to %p to print the pointer.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>

IMO, it's better to drop the address printing itself.
We don't want to expose the kernel address any longer.

Care to rewrite the patch?


thanks,

Takashi


> ---
>  sound/isa/gus/gus_mem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/isa/gus/gus_mem.c b/sound/isa/gus/gus_mem.c
> index 4ac76f4..63e790f 100644
> --- a/sound/isa/gus/gus_mem.c
> +++ b/sound/isa/gus/gus_mem.c
> @@ -306,7 +306,7 @@ static void snd_gf1_mem_info_read(struct snd_info_entry *entry,
>  	used = 0;
>  	for (block = alloc->first, i = 0; block; block = block->next, i++) {
>  		used += block->size;
> -		snd_iprintf(buffer, "Block %i at 0x%lx onboard 0x%x size %i (0x%x):\n", i, (long) block, block->ptr, block->size, block->size);
> +		snd_iprintf(buffer, "Block %i at 0x%p onboard 0x%x size %i (0x%x):\n", i, block, block->ptr, block->size, block->size);
>  		if (block->share ||
>  		    block->share_id[0] || block->share_id[1] ||
>  		    block->share_id[2] || block->share_id[3])
> -- 
> 2.11.0
> 
>