linux-kernel - Re: [PATCH v3] signal: trace_signal_deliver when signal_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <AF4D908CC0E2A24EB308A26962C8C3BDEB16FB@DGGEMI530-MBX.china.huawei.com>
Date:   Tue, 23 Apr 2019 14:25:07 +0000
From:   weizhenliang <weizhenliang@...wei.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "oleg@...hat.com" <oleg@...hat.com>,
        "colona@...sta.com" <colona@...sta.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "christian@...uner.io" <christian@...uner.io>,
        "arnd@...db.de" <arnd@...db.de>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "deepa.kernel@...il.com" <deepa.kernel@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit

On 04/23, Greg KH wrote:
>On Mon, Apr 22, 2019 at 10:59:50PM +0800, Zhenliang Wei wrote:
>> In the fixes commit, removing SIGKILL from each thread signal mask and 
>> executing "goto fatal" directly will skip the call to 
>> "trace_signal_deliver". At this point, the delivery tracking of the 
>> SIGKILL signal will be inaccurate.
>> 
>> Therefore, we need to add trace_signal_deliver before "goto fatal"
>> after executing sigdelset.
>> 
>> Note: The action[SIGKILL] must be SIG_DFL, and SEND_SIG_NOINFO matches 
>> the fact that SIGKILL doesn't have any info.
>> 
>> Acked-by: Christian Brauner <christian@...uner.io>
>> Fixes: cf43a757fd4944 ("signal: Restore the stop PTRACE_EVENT_EXIT")
>> Signed-off-by: Zhenliang Wei <weizhenliang@...wei.com>
>> ---
>>  kernel/signal.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/kernel/signal.c b/kernel/signal.c index 
>> 227ba170298e..0f69ada376ef 100644
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig)
>>  	if (signal_group_exit(signal)) {
>>  		ksig->info.si_signo = signr = SIGKILL;
>>  		sigdelset(&current->pending.signal, SIGKILL);
>> +		trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL);
>>  		recalc_sigpending();
>>  		goto fatal;
>>  	}
>> --
>> 2.14.1.windows.1
>> 
>> 
>
><formletter>
>
>This is not the correct way to submit patches for inclusion in the stable kernel tree.  Please read:
>    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>for how to do this properly.
>
></formletter>

Thans for your reply, is that mean I still need to add tags
	Cc: stable@...r.kernel.org
if I want to submit this patch to the stable kernel tree?

Is my understanding correct or missing?

Wei