linux-kernel - Re: [PATCH 1/2] dt-bindings: adc: mt8183: add binding document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c7f244f-4111-9e28-5134-8f108b1dbafa@gmail.com>
Date:   Tue, 23 Apr 2019 16:35:49 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Zhiyong Tao <zhiyong.tao@...iatek.com>, robh+dt@...nel.org,
        jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net
Cc:     srv_heupstream@...iatek.com, hui.liu@...iatek.com,
        yingjoe.chen@...iatek.com, sean.wang@...iatek.com,
        erin.lo@...iatek.com, eddie.huang@...iatek.com,
        s.hauer@...gutronix.de, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-iio@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: adc: mt8183: add binding document



On 22/04/2019 13:54, Zhiyong Tao wrote:
> The commit adds mt8183 compatible node in binding document.
> 
> Signed-off-by: Zhiyong Tao <zhiyong.tao@...iatek.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> index 0df9befdaecc..05bc79d8483c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> @@ -15,6 +15,7 @@ Required properties:
>      - "mediatek,mt2712-auxadc": For MT2712 family of SoCs
>      - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
>      - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
> +    - "mediatek,mt8183-auxadc": For MT8183 family of SoCs
>    - reg: Address range of the AUXADC unit.
>    - clocks: Should contain a clock specifier for each entry in clock-names
>    - clock-names: Should contain "main".
> 

You are missing the logic in the driver to bind against this compatible.
If there is nothing different from other SoCs then you could add a compatible
with a fallback, like:

"mediatek,mt8183-auxadc", "mediatek,mt7622-auxadc": For MT8183 family of SoCs

Regards,
Matthias