linux-kernel - Re: [PATCH v3 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d810fcf-8d31-f07e-d94a-a127127e97cd@cogentembedded.com>
Date:   Tue, 23 Apr 2019 17:44:15 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jiada Wang <jiada_wang@...tor.com>, rui.zhang@...el.com,
        edubezval@...il.com, daniel.lezcano@...aro.org
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        horms+renesas@...ge.net.au, niklas.soderlund+renesas@...natech.se,
        geert+renesas@...der.be, marek.vasut+renesas@...il.com,
        kuninori.morimoto.gx@...esas.com, hien.dang.eb@...esas.com,
        fabrizio.castro@...renesas.com, dien.pham.ry@...esas.com,
        biju.das@...renesas.com, erosca@...adit-jv.com,
        george_davis@...tor.com, joshua_frkuska@...tor.com
Subject: Re: [PATCH v3 2/2] thermal: rcar_gen3_thermal: disable interrupt in
 .remove

On 04/23/2019 05:14 PM, Jiada Wang wrote:

> Currently IRQ is remain enabled after .remove, later if device is probed,

   IRQ remains enabled.

> IRQ is requested before .thermal_init, this may cause IRQ function be
> called before device is initialized.
> 
> this patch by disable interrupt in .remove, to ensure irq function

   s/by disable/disables/.

> only be called after device is fully initialized.
> 
> Signed-off-by: Jiada Wang <jiada_wang@...tor.com>
[...]

MBR, Sergei