linux-kernel - Re: [RESEND1, PATCH 1/2] fuse: convert printk -> pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpegt9DRmwKksR0QSA7NzQP_=a=yJybdL9mOP1cw5goGkdgw@mail.gmail.com>
Date:   Tue, 23 Apr 2019 16:57:58 +0200
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Kirill Smelkov <kirr@...edi.com>
Cc:     Miklos Szeredi <mszeredi@...hat.com>,
        Brian Foster <bfoster@...hat.com>,
        Maxim Patlasov <mpatlasov@...allels.com>,
        Anatol Pomozov <anatol.pomozov@...il.com>,
        Pavel Emelyanov <xemul@...nvz.org>,
        Andrew Gallagher <andrewjcg@...com>,
        "Anand V . Avati" <avati@...hat.com>,
        Alexey Kuznetsov <kuznet@...tuozzo.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        Constantine Shulyupin <const@...elinux.com>,
        Chad Austin <chadaustin@...com>,
        Dan Schatzberg <dschatzberg@...com>,
        linux-fsdevel@...r.kernel.org,
        fuse-devel <fuse-devel@...ts.sourceforge.net>,
        linux-kernel@...r.kernel.org, Han-Wen Nienhuys <hanwen@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RESEND1, PATCH 1/2] fuse: convert printk -> pr_*

On Wed, Mar 27, 2019 at 10:15 AM Kirill Smelkov <kirr@...edi.com> wrote:
>
> Functions, like pr_err, are a more modern variant of printing compared to
> printk. They could be used to denoise sources by using needed level in
> the print function name, and by automatically inserting per-driver /
> function / ... print prefix as defined by pr_fmt macro. pr_* are also
> said to be used in Documentation/process/coding-style.rst and more
> recent code - for example overlayfs - uses them instead of printk.
>
> Convert CUSE and FUSE to use the new pr_* functions.
>
> CUSE output stays completely unchanged, while FUSE output is amended a
> bit for "trying to steal weird page" warning - the second line now comes
> also with "fuse:" prefix. I hope it is ok.

Yep.  Applied, thanks.

Miklos