lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 23 Apr 2019 19:28:53 +0200
From:   Marcel Holtmann <>
To:     Chen-Yu Tsai <>
Cc:     Johan Hedberg <>,
        Chen-Yu Tsai <>,,, Imre Kaloz <>,
Subject: Re: [PATCH] Bluetooth: hci_bcm: Fix empty regulator supplies for
 Intel Macs

Hi Chen-Yu,

> The code path for Macs goes through bcm_apple_get_resources(), which
> skips over the code that sets up the regulator supplies. As a result,
> the call to regulator_bulk_enable() / regulator_bulk_disable() results
> in a NULL pointer dereference.
> This was reported on the Bugzilla, bug 202963.
> Unbreak Broadcom Bluetooth support on Intel Macs by checking if the
> supplies were set up before enabling or disabling them.
> The same does not need to be done for the clocks, as the common clock
> framework API checks for NULL pointers.
> Fixes: 75d11676dccb ("Bluetooth: hci_bcm: Add support for regulator supplies")
> Cc: <> # 5.0.x
> Signed-off-by: Chen-Yu Tsai <>
> ---
> I do not own a Mac, so this needs to be tested by someone else.
> ---
> drivers/bluetooth/hci_bcm.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)

patch has been applied to bluetooth-next tree.



Powered by blists - more mailing lists