linux-kernel - Re: [PATCH -next] scsi: qedf: remove set but not used variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D8E684C7.18978%skashyap@marvell.com>
Date:   Wed, 24 Apr 2019 15:56:22 +0000
From:   Saurav Kashyap <skashyap@...vell.com>
To:     Yue Haibing <yuehaibing@...wei.com>,
        "QLogic-Storage-Upstream@...ium.com" 
        <QLogic-Storage-Upstream@...ium.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH -next] scsi: qedf: remove set but not used variables

Hi,

-----Original Message-----
From: <linux-scsi-owner@...r.kernel.org> on behalf of Yue Haibing
<yuehaibing@...wei.com>
Date: Tuesday, 23 April 2019 at 8:11 PM
To: "QLogic-Storage-Upstream@...ium.com"
<QLogic-Storage-Upstream@...ium.com>, "jejb@...ux.ibm.com"
<jejb@...ux.ibm.com>, "martin.petersen@...cle.com"
<martin.petersen@...cle.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, YueHaibing
<yuehaibing@...wei.com>
Subject: [PATCH -next] scsi: qedf: remove set but not used variables
Resent-From: <Saurav.Kashyap@...ium.com>
Resent-Date: Tuesday, 23 April 2019 at 8:12 PM

>From: YueHaibing <yuehaibing@...wei.com>
>
>Fixes gcc '-Wunused-but-set-variable' warnings:
>
>drivers/scsi/qedf/qedf_els.c: In function 'qedf_process_els_compl':
>drivers/scsi/qedf/qedf_els.c:149:20: warning: variable 'sc_cmd' set but
>not used [-Wunused-but-set-variable]
>drivers/scsi/qedf/qedf_els.c:148:28: warning: variable 'task_ctx' set but
>not used [-Wunused-but-set-variable]
>drivers/scsi/qedf/qedf_els.c: In function 'qedf_send_srr':
>drivers/scsi/qedf/qedf_els.c:612:6: warning: variable 'sid' set but not
>used [-Wunused-but-set-variable]
>
>They are never used since introduction.
>
>Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>---
> drivers/scsi/qedf/qedf_els.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
>diff --git a/drivers/scsi/qedf/qedf_els.c b/drivers/scsi/qedf/qedf_els.c
>index 1781e73..d900c89e 100644
>--- a/drivers/scsi/qedf/qedf_els.c
>+++ b/drivers/scsi/qedf/qedf_els.c
>@@ -145,9 +145,6 @@ static int qedf_initiate_els(struct qedf_rport
>*fcport, unsigned int op,
> void qedf_process_els_compl(struct qedf_ctx *qedf, struct fcoe_cqe *cqe,
> 	struct qedf_ioreq *els_req)
> {
>-	struct fcoe_task_context *task_ctx;
>-	struct scsi_cmnd *sc_cmd;
>-	uint16_t xid;
> 	struct fcoe_cqe_midpath_info *mp_info;
> 
> 	QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_ELS, "Entered with xid = 0x%x"
>@@ -158,10 +155,6 @@ void qedf_process_els_compl(struct qedf_ctx *qedf,
>struct fcoe_cqe *cqe,
> 	/* Kill the ELS timer */
> 	cancel_delayed_work(&els_req->timeout_work);
> 
>-	xid = els_req->xid;
>-	task_ctx = qedf_get_task_mem(&qedf->tasks, xid);
>-	sc_cmd = els_req->sc_cmd;
>-
> 	/* Get ELS response length from CQE */
> 	mp_info = &cqe->cqe_info.midpath_info;
> 	els_req->mp_req.resp_len = mp_info->data_placement_size;
>@@ -609,7 +602,7 @@ static int qedf_send_srr(struct qedf_ioreq
>*orig_io_req, u32 offset, u8 r_ctl)
> 	struct qedf_rport *fcport;
> 	struct fc_lport *lport;
> 	struct qedf_els_cb_arg *cb_arg = NULL;
>-	u32 sid, r_a_tov;
>+	u32 r_a_tov;
> 	int rc;
> 
> 	if (!orig_io_req) {
>@@ -635,7 +628,6 @@ static int qedf_send_srr(struct qedf_ioreq
>*orig_io_req, u32 offset, u8 r_ctl)
> 
> 	qedf = fcport->qedf;
> 	lport = qedf->lport;
>-	sid = fcport->sid;
> 	r_a_tov = lport->r_a_tov;
> 
> 	QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_ELS, "Sending SRR orig_io=%p, "
>-- 
>2.7.0

Thanks,
Acked-by: Saurav Kashyap <skashyap@...vell.com>
>
>