linux-kernel - Re: [PATCH net v4] net/ncsi: handle overflow when incrementing mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190423.211618.1009243431874480506.davem@davemloft.net>
Date:   Tue, 23 Apr 2019 21:16:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     taoren@...com
Cc:     maximmi@...lanox.com, bgolaszewski@...libre.com,
        sam@...dozajonas.com, jakub.kicinski@...ronome.com, joel@....id.au,
        andrew@...id.au, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH net v4] net/ncsi: handle overflow when incrementing mac
 address

From: Tao Ren <taoren@...com>
Date: Wed, 24 Apr 2019 01:43:32 +0000

> Previously BMC's MAC address is calculated by simply adding 1 to the
> last byte of network controller's MAC address, and it produces incorrect
> result when network controller's MAC address ends with 0xFF.
> 
> The problem can be fixed by calling eth_addr_inc() function to increment
> MAC address; besides, the MAC address is also validated before assigning
> to BMC.
> 
> Fixes: cb10c7c0dfd9 ("net/ncsi: Add NCSI Broadcom OEM command")
> Signed-off-by: Tao Ren <taoren@...com>

Applied and queued up for -stable, thanks everyone.