linux-kernel - Re: Re: [PATCH v4] signal: trace_signal_deliver when signal_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190424161641.GI16167@redhat.com>
Date:   Wed, 24 Apr 2019 18:16:42 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     weizhenliang <weizhenliang@...wei.com>
Cc:     Christian Brauner <christian@...uner.io>,
        "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "colona@...sta.com" <colona@...sta.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "deepa.kernel@...il.com" <deepa.kernel@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: Re: [PATCH v4] signal: trace_signal_deliver when
 signal_group_exit

On 04/24, weizhenliang wrote:
>
> On 04/24, Oleg wrote:
> >On 04/24, Christian Brauner wrote:
> >>
> >> On Wed, Apr 24, 2019 at 08:52:38PM +0800, Zhenliang Wei wrote:
> >>
> >> > Reviewed-by: Oleg Nesterov <oleg@...hat.com>
> >
> >Yes, but ...
> >
> >> > Reported-by: kbuild test robot <lkp@...el.com>
> >
> >Hmm, really?
>
> Yes, the kbuild test robot says that if I fix the problem with the third parameter type,
> I should add this tag. What is wrong or missing?

But this patch does not fix the problem reported by robot, your patch
(which introduced that problem) was dropped, the problem has gone.

With this "Reported-by: kbuild test robot <lkp@...el.com>" tag it looks
as if test-robot has found the problem you are trying to fix: the lack of
trace_signal_deliver(SIGKILL).

Oleg.