linux-kernel - Re: [PATCH] iommu/amd: flush not present cache in iommu_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPL0++7G-=FChbMnHoDfh=SnUW3B3YGi-z7Wy9Dq2D6zzQshOg@mail.gmail.com>
Date:   Wed, 24 Apr 2019 17:25:29 +0100
From:   Tom Murphy <tmurphy@...sta.com>
To:     Joerg Roedel <joro@...tes.org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        Tom Murphy <murphyt7@....ie>
Subject: Re: [PATCH] iommu/amd: flush not present cache in iommu_map_page

On Wed, Apr 24, 2019 at 4:55 PM Joerg Roedel <joro@...tes.org> wrote:
>
> On Wed, Apr 24, 2019 at 07:58:19AM -0700, Christoph Hellwig wrote:
> > I'd be tempted to do that.  But lets just ask Joerg if he has
> > any opinion..
>
> The reason was that it is an unlikely path, as hardware implementations
> are not allowed to set this bit. It is purely for emulated AMD IOMMUs.
> I have not measured whether this annotation has any performance
> benefit, but I find it more readable at least.

In that case I will keep it in.

>
> Regards,
>
>         Joerg
>
> PS: Why did you drop me from the Cc list of the previous replies?