linux-kernel - Re: [PATCH 02/25] drm: kirin: Remove HISI_KIRIN_DW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLXeU7skJiy2J4ZYOFtym6pDUuzY3QT+e3F1D8jE4pYC0w@mail.gmail.com>
Date:   Wed, 24 Apr 2019 09:49:49 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        Chen Feng <puck.chen@...ilicon.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Xinliang Liu <z.liuxinliang@...ilicon.com>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        Rongrong Zou <zourongrong@...il.com>
Subject: Re: [PATCH 02/25] drm: kirin: Remove HISI_KIRIN_DW_DSI config option

On Wed, Apr 24, 2019 at 9:39 AM Sam Ravnborg <sam@...nborg.org> wrote:
>
> Hi John.
>
> On Tue, Apr 23, 2019 at 04:20:33PM -0700, John Stultz wrote:
> > The CONFIG_HISI_KIRIN_DW_DSI option is only used w/ kirin
> > driver, so cut out the middleman and condense the config
> > logic down.
> >
> > Cc: Xinliang Liu <z.liuxinliang@...ilicon.com>
> > Cc: Rongrong Zou <zourongrong@...il.com>
> > Cc: Xinwei Kong <kong.kongxinwei@...ilicon.com>
> > Cc: Chen Feng <puck.chen@...ilicon.com>
> > Cc: David Airlie <airlied@...ux.ie>
> > Cc: Daniel Vetter <daniel@...ll.ch>
> > Cc: dri-devel <dri-devel@...ts.freedesktop.org>
> > Signed-off-by: John Stultz <john.stultz@...aro.org>
> > ---
> >  drivers/gpu/drm/hisilicon/kirin/Kconfig  | 10 +---------
> >  drivers/gpu/drm/hisilicon/kirin/Makefile |  4 ++--
> >  2 files changed, 3 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/hisilicon/kirin/Kconfig b/drivers/gpu/drm/hisilicon/kirin/Kconfig
> > index 499f644..6ef7906 100644
> > --- a/drivers/gpu/drm/hisilicon/kirin/Kconfig
> > +++ b/drivers/gpu/drm/hisilicon/kirin/Kconfig
> > @@ -4,16 +4,8 @@ config DRM_HISI_KIRIN
> >       select DRM_KMS_HELPER
> >       select DRM_GEM_CMA_HELPER
> >       select DRM_KMS_CMA_HELPER
> > -     select HISI_KIRIN_DW_DSI
> > +     select DRM_MIPI_DSI
> >       help
> >         Choose this option if you have a hisilicon Kirin chipsets(hi6220).
> >         If M is selected the module will be called kirin-drm.
> >
> > -config HISI_KIRIN_DW_DSI
> > -     tristate "HiSilicon Kirin specific extensions for Synopsys DW MIPI DSI"
> > -     depends on DRM_HISI_KIRIN
> > -     select DRM_MIPI_DSI
> > -     help
> > -      This selects support for HiSilicon Kirin SoC specific extensions for
> > -      the Synopsys DesignWare DSI driver. If you want to enable MIPI DSI on
> > -      hi6220 based SoC, you should selet this option.
>
> Nice simplification. We are now down to two very small Kconfig files.
> Consider to merge them into one Kconfig file in the top-level dir.
>

Part of this cleanup is so that we can add another device option in a
later commit (though not in this series), so unless folks are
generally wanting to consolidate Kconfigs into the top level, it may
be premature to do so now only to later undo it when there are more
kirin specific options. I'm fine with whichever, I just want to make
sure that's clear.

thanks
-john