linux-kernel - Re: [PATCH net v2 2/2] net/ncsi: handle overflow when incrementing mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <F686273E-C5DC-441D-BF10-2BAB93481FE8@fb.com>
Date:   Wed, 24 Apr 2019 05:30:38 +0000
From:   Tao Ren <taoren@...com>
To:     "David S . Miller" <davem@...emloft.net>,
        Maxim Mikityanskiy <maximmi@...lanox.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Samuel Mendoza-Jonas <sam@...dozajonas.com>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>
Subject: Re: [PATCH net v2 2/2] net/ncsi: handle overflow when incrementing
 mac address

Please ignore this email. Something was wrong with my email client: the email was supposed to be delivered 8 hours ago but surprisingly it arrived now. Sorry about the noise..

- Tao

On 4/23/19, 9:41 PM, "openbmc on behalf of Tao Ren" <openbmc-bounces+taoren=fb.com@...ts.ozlabs.org on behalf of taoren@...com> wrote:
> Previously BMC's MAC address is calculated by simply adding 1 to the
> last byte of network controller's MAC address, and it produces incorrect
> result when network controller's MAC address ends with 0xFF.
>  
> The problem can be fixed by calling "net_addr_inc" function to increment
> MAC address; besides, the MAC address is also validated before assigning
> to BMC.
>  
> Fixes: cb10c7c0dfd9 ("net/ncsi: Add NCSI Broadcom OEM command")
> Signed-off-by: Tao Ren <taoren@...com>