linux-kernel - Re: [PATCH] watchdog: machzwd: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190424172813.GA29860@roeck-us.net>
Date:   Wed, 24 Apr 2019 10:28:13 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] watchdog: machzwd: Mark expected switch fall-through

On Wed, Apr 24, 2019 at 12:01:03PM -0500, Gustavo A. R. Silva wrote:
> Hi Guenter,
> 
> I wonder if you took this in you watchdog-next branch.
> 

It is in branch watchdog-next of
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git

waiting for Wim to pick it up.

Guenter

> Thanks
> --
> Gustavo
> 
> On 4/10/19 3:51 PM, Gustavo A. R. Silva wrote:
> > 
> > 
> > On 4/10/19 3:35 PM, Guenter Roeck wrote:
> >> On Wed, Apr 10, 2019 at 01:49:05PM -0500, Gustavo A. R. Silva wrote:
> >>> In preparation to enabling -Wimplicit-fallthrough, mark switch
> >>> cases where we are expecting to fall through.
> >>>
> >>> This patch fixes the following warnings:
> >>>
> >>> drivers/watchdog/machzwd.c: In function ‘zf_set_timer’:
> >>> ./arch/x86/include/asm/io.h:355:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >>>  #define outw outw
> >>> drivers/watchdog/machzwd.c:80:53: note: in expansion of macro ‘outw’
> >>>  #define zf_writew(port, data)  { outb(port, INDEX); outw(data, DATA_W); }
> >>>                                                      ^~~~
> >>> drivers/watchdog/machzwd.c:179:3: note: in expansion of macro ‘zf_writew’
> >>>    zf_writew(COUNTER_1, new);
> >>>    ^~~~~~~~~
> >>> drivers/watchdog/machzwd.c:180:2: note: here
> >>>   case WD2:
> >>>   ^~~~
> >>>
> >>> Warning level 3 was used: -Wimplicit-fallthrough=3
> >>>
> >>> This patch is part of the ongoing efforts to enable
> >>> -Wimplicit-fallthrough.
> >>>
> >>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> >>
> >> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> >>
> > 
> > Thank you, Guenter.
> > --
> > Gustavo
> > 
> >>> ---
> >>>  drivers/watchdog/machzwd.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/watchdog/machzwd.c b/drivers/watchdog/machzwd.c
> >>> index 88d823d87a4b..108928dbc754 100644
> >>> --- a/drivers/watchdog/machzwd.c
> >>> +++ b/drivers/watchdog/machzwd.c
> >>> @@ -177,6 +177,7 @@ static inline void zf_set_timer(unsigned short new, unsigned char n)
> >>>  	switch (n) {
> >>>  	case WD1:
> >>>  		zf_writew(COUNTER_1, new);
> >>> +		/* fall through */
> >>>  	case WD2:
> >>>  		zf_writeb(COUNTER_2, new > 0xff ? 0xff : new);
> >>>  	default:
> >>> -- 
> >>> 2.21.0
> >>>