linux-kernel - Re: [PATCH v4 20/26] leds: aat1290: Use generic support for composing LED names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <713cd359-4c93-7841-c3b7-bbf3d3ceec45@gmail.com>
Date:   Wed, 24 Apr 2019 20:16:55 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, robh@...nel.org, dtor@...gle.com,
        linux@...ck-us.net
Subject: Re: [PATCH v4 20/26] leds: aat1290: Use generic support for composing
 LED names

On 4/24/19 3:57 PM, Pavel Machek wrote:
> Hi!
> 
>> Switch to using generic LED support for composing LED class
>> device name.
>>
>> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> 
>> @@ -257,9 +257,6 @@ static int aat1290_led_parse_dt(struct aat1290_led *led,
>>   		return -EINVAL;
>>   	}
>>   
>> -	led_cdev->name = of_get_property(child_node, "label", NULL) ? :
>> -						child_node->name;
>> -
>>   	ret = of_property_read_u32(child_node, "led-max-microamp",
>>   				&cfg->max_mm_current);
>>   	/*
>> @@ -469,6 +466,7 @@ static int aat1290_led_probe(struct platform_device *pdev)
>>   	struct aat1290_led *led;
>>   	struct led_classdev *led_cdev;
>>   	struct led_classdev_flash *fled_cdev;
>> +	struct led_init_data init_data = {};
> 
> You can do directly = { .devicename = ...; }, at least for the name.

In previous versions I applied similar approach in few places but
later figured out it will be more consistent if all assignments are
next to each other.

> Anyway, that's a detail.
> 
> 8, 10, 12, 14, 16, 18, 20: Acked-by: Pavel Machek <pavel@....cz>

Thanks!

-- 
Best regards,
Jacek Anaszewski