linux-kernel - Re: [PATCH net-next] net: socket: Fix missing break in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0Ak95EUq6-6ASHKEKw=x+9_+MO5ZaFcctaS4esz__J3A@mail.gmail.com>
Date:   Wed, 24 Apr 2019 20:45:46 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH net-next] net: socket: Fix missing break in switch statement

On Wed, Apr 24, 2019 at 5:33 PM Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
>
> Add missing break statement in order to prevent the code from falling
> through to cases SIOCGSTAMP_NEW and SIOCGSTAMPNS_NEW.
>
> This bug was found thanks to the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Fixes: 0768e17073dc ("net: socket: implement 64-bit timestamps")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
Acked-by: Arnd Bergmann <arnd@...db.de>

I had just prepared the same patch after Dan told me about the issue today,
but you managed to submit it first.

Thanks for the fix!

     Arnd