linux-kernel - Re: [PATCH 24/25] drm: kirin: Pass driver data to crtc init and plane init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLWmrabPxnpN7T_9KCLNrpzj0dnzbNs8vLhz+GBGyRxp_Q@mail.gmail.com>
Date:   Wed, 24 Apr 2019 12:32:38 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Xu YiPing <xuyiping@...ilicon.com>,
        David Airlie <airlied@...ux.ie>,
        Chen Feng <puck.chen@...ilicon.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Xinliang Liu <z.liuxinliang@...ilicon.com>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        Rongrong Zou <zourongrong@...il.com>
Subject: Re: [PATCH 24/25] drm: kirin: Pass driver data to crtc init and plane init

On Wed, Apr 24, 2019 at 10:09 AM Sam Ravnborg <sam@...nborg.org> wrote:
> On Tue, Apr 23, 2019 at 04:20:55PM -0700, John Stultz wrote:
> >  static int kirin_drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc,
> > -                      struct drm_plane *plane)
> > +                             struct drm_plane *plane,
> > +                             const struct kirin_drm_data *driver_data)
>
> Indent looks wrong here.
>
..
> >       ret = drm_universal_plane_init(dev, &kplane->base, 1,
> > +                             driver_data->plane_funcs,
> > +                             driver_data->channel_formats,
> > +                             driver_data->channel_formats_cnt,
> > +                             NULL, type, NULL);
> Indent looks wrong here.

Thanks! I've now fixed those up.

> I missed where ade_driver_data came from.
> This looks an extra patch to intoduce driver_data,
> that maybe should be merged with an earlier version?

I'm not sure I'm following you here. Can you clarify a bit more?

thanks
-john