linux-kernel - Re: [PATCH 0/6] libsas: Some minor improvements and tidy-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a597316-4d52-13bb-35ce-676350b19f5d@huawei.com>
Date:   Wed, 24 Apr 2019 21:00:28 +0100
From:   John Garry <john.garry@...wei.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     <jejb@...ux.vnet.ibm.com>, <linuxarm@...wei.com>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <yanaijie@...wei.com>, <chenxiang66@...ilicon.com>,
        <luojiaxing@...wei.com>
Subject: Re: [PATCH 0/6] libsas: Some minor improvements and tidy-up

On 16/04/2019 00:33, Martin K. Petersen wrote:
>
> John,
>
>> This patchset introduces some minor improvements and tidy-up, including:
>> - fix PHY info in sysfs for PHY events
>> - min pathway rate programming improvement
>> - some other tidy-up and neatening
>
> Applied to 5.2/scsi-queue, thanks!
>

Hi Martin,

Sorry for the slow response.

> One thing that always bugged me is the ambiguous "ex" prefix for many
> libsas log messages.And in a way, your patch #3 makes things worse by
> replacing the more descriptive "Expander" with "ex". It does make things
> more consistent, though.

OK, understood. Personally I prefer the brevity of "ex". However, apart 
from this, adding the SAS address to the log does add value.

>
> I'd really like to see all the libsas messages be cleaned up with a
> sensible prefix and a consistent format where possible.

So all libsas messages do have the "sas: " prefix, but they still can be 
vague/inconsistent at times.

Anyway, I'll check what can be done here.

Thanks,


>