linux-kernel - Re: [PATCH] nds32: vdso: drop unnecessary cc-ldoption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEbi=3fn42-rcXOh28N09G9Gng8o9RE8_A8=ow0=JeMEXVF_ig@mail.gmail.com>
Date:   Wed, 24 Apr 2019 14:56:39 +0800
From:   Greentime Hu <green.hu@...il.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Vincent Chen <deanbo422@...il.com>,
        clang-built-linux@...glegroups.com,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nds32: vdso: drop unnecessary cc-ldoption

Hi Nick & Yamada,

Nick Desaulniers <ndesaulniers@...gle.com> 於 2019年4月24日 週三 上午5:19寫道：
>
> Towards the goal of removing cc-ldoption, it seems that --hash-style=
> was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> of binutils for the kernel according to
> Documentation/process/changes.rst is 2.20.
>
> Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> Cc: clang-built-linux@...glegroups.com
> Suggested-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> ---
>  arch/nds32/kernel/vdso/Makefile | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile
> index e6c50a701313..d379645cad74 100644
> --- a/arch/nds32/kernel/vdso/Makefile
> +++ b/arch/nds32/kernel/vdso/Makefile
> @@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o
>  targets := $(obj-vdso) vdso.so vdso.so.dbg
>  obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
>
> -ccflags-y := -shared -fno-common -fno-builtin
> -ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
> -               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> -ccflags-y += -fPIC -Wl,-shared -g
> +ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \
> +       -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv
>
>  # Disable gcov profiling for VDSO code
>  GCOV_PROFILE := n

Thank you.
Acked-by: Greentime Hu <greentime@...estech.com>