linux-kernel - Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91deac040a35235e52079cdbdef2f425@codeaurora.org>
Date:   Wed, 24 Apr 2019 12:38:44 +0530
From:   Balakrishna Godavarthi <bgodavar@...eaurora.org>
To:     Harish Bandi <c-hbandi@...eaurora.org>
Cc:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-bluetooth@...r.kernel.org, hemantg@...eaurora.org,
        linux-arm-msm@...r.kernel.org,
        linux-bluetooth-owner@...r.kernel.org
Subject: Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address
 missing in dts

Hi Harish,

On 2019-04-24 12:34, Harish Bandi wrote:
> Hi Balakrishna,
> 
> On 2019-04-23 22:05, Marcel Holtmann wrote:
>> Hi Balakrishna,
>> 
>>> When flag HCI_QUIRK_USE_BDADDR_PROPERTY is set, we will read the
>>> bluetooth address from dts. If the bluetooth address node is missing
>>> from the dts we will enable it controller UNCONFIGURED state.
>>> This patch enables the normal flow even if the BD address is missing
>>> from the dts tree.
>>> 
>>> Signed-off-by: Balakrishna Godavarthi <bgodavar@...eaurora.org>
>>> ---
>>> net/bluetooth/hci_core.c | 2 --
>>> 1 file changed, 2 deletions(-)
>> 
>> can I get an ACK for this one?
>> 
>> Regards
>> 
>> Marcel
> 
> nit: it would be better if we print error message, if bd address 
> missing in dts.
> 
> tested 20 times with bd address missing in dts.
> tested 20 times with bd address available in dts.
> 
> Tested-by: Harish Bandi <c-hbandi@...eaurora.org>
> 
> 
> Thanks,
> Harish

Thanks for testing will note this improvement and send an incremental 
patch.

-- 
Regards
Balakrishna.