linux-kernel - Re: [PATCH] nds32: vdso: drop unnecessary cc-ldoption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEbi=3fSP4OkxkDPYBuae5mQ0U3hwpK1K6W2haqAt1kKDaz43g@mail.gmail.com>
Date:   Wed, 24 Apr 2019 16:04:17 +0800
From:   Greentime Hu <green.hu@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Vincent Chen <deanbo422@...il.com>,
        clang-built-linux@...glegroups.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nds32: vdso: drop unnecessary cc-ldoption

Masahiro Yamada <yamada.masahiro@...ionext.com> 於 2019年4月24日 週三 下午3:54寫道：
>
> On Wed, Apr 24, 2019 at 3:59 PM Greentime Hu <green.hu@...il.com> wrote:
> >
> > Hi Nick & Yamada,
> >
> > Nick Desaulniers <ndesaulniers@...gle.com> 於 2019年4月24日 週三 上午5:19寫道：
> > >
> > > Towards the goal of removing cc-ldoption, it seems that --hash-style=
> > > was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> > > of binutils for the kernel according to
> > > Documentation/process/changes.rst is 2.20.
> > >
> > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> > > Cc: clang-built-linux@...glegroups.com
> > > Suggested-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > > Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> > > ---
> > >  arch/nds32/kernel/vdso/Makefile | 6 ++----
> > >  1 file changed, 2 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile
> > > index e6c50a701313..d379645cad74 100644
> > > --- a/arch/nds32/kernel/vdso/Makefile
> > > +++ b/arch/nds32/kernel/vdso/Makefile
> > > @@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o
> > >  targets := $(obj-vdso) vdso.so vdso.so.dbg
> > >  obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
> > >
> > > -ccflags-y := -shared -fno-common -fno-builtin
> > > -ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \
> > > -               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> > > -ccflags-y += -fPIC -Wl,-shared -g
> > > +ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \
> > > +       -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv
> > >
> > >  # Disable gcov profiling for VDSO code
> > >  GCOV_PROFILE := n
> >
> > Thank you.
> > Acked-by: Greentime Hu <greentime@...estech.com>
>
>
> Who do you expect to pick up this patch?
>
> You are the NDS32 maintainer
> according to MAINTAINERS.
>
>
> ANDES ARCHITECTURE
> M:      Greentime Hu <green.hu@...il.com>
> M:      Vincent Chen <deanbo422@...il.com>
> T:      git https://github.com/andestech/linux.git
> S:      Supported
> F:      arch/nds32/
> F:      Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt
> F:      Documentation/devicetree/bindings/nds32/
> K:      nds32
> N:      nds32
>
>
> You do not maintain https://github.com/andestech/linux.git any more, do you?

Hi Yamada,

I think I should update this MAINTAINERS file.
I will pick it in this repo
https://git.kernel.org/pub/scm/linux/kernel/git/greentime/linux.git